Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically detect imported version #30

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

costela
Copy link
Member

@costela costela commented Jan 19, 2024

This is an alternative to #29.

It automatically detects the module version used when importing the lib.

It is unfortunately a bit tricky to test, since it depends on import behavior, but the approach has been used internally for years.

@costela costela mentioned this pull request Jan 19, 2024
@costela costela requested a review from obitech January 19, 2024 15:05
tracer.go Show resolved Hide resolved
Copy link
Member

@obitech obitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obitech obitech merged commit cf6d021 into main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants